]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
netrom: Fix a data-race around sysctl_netrom_transport_timeout
authorJason Xing <kernelxing@tencent.com>
Mon, 4 Mar 2024 08:20:38 +0000 (16:20 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 7 Mar 2024 09:36:58 +0000 (10:36 +0100)
We need to protect the reader reading the sysctl value because the
value can be changed concurrently.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Jason Xing <kernelxing@tencent.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/netrom/af_netrom.c

index 0eed00184adf454d2e06bb44330c079a402a959e..4d0e0834d527beadada324ebb0edab5f58bb0d0c 100644 (file)
@@ -453,7 +453,7 @@ static int nr_create(struct net *net, struct socket *sock, int protocol,
        nr_init_timers(sk);
 
        nr->t1     =
-               msecs_to_jiffies(sysctl_netrom_transport_timeout);
+               msecs_to_jiffies(READ_ONCE(sysctl_netrom_transport_timeout));
        nr->t2     =
                msecs_to_jiffies(sysctl_netrom_transport_acknowledge_delay);
        nr->n2     =