]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
nvmet: report ns's vwc not present
authorGuixin Liu <kanie@linux.alibaba.com>
Wed, 13 Nov 2024 10:18:39 +0000 (18:18 +0800)
committerKeith Busch <kbusch@kernel.org>
Wed, 13 Nov 2024 16:51:17 +0000 (08:51 -0800)
Currently, we report that controller has vwc even though the ns may
not have vwc. Report ns's vwc not present when not buffered_io or
backdev doesn't have vwc.

Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/target/admin-cmd.c

index 0a9fdc533186192da1e347fccd786d608a808c75..934b401fbc2ffb2168cb5cf5ce3f077f513215c8 100644 (file)
@@ -934,6 +934,13 @@ static void nvmet_execute_id_cs_indep(struct nvmet_req *req)
                id->nsattr |= NVME_NS_ATTR_RO;
        if (req->ns->bdev && !bdev_nonrot(req->ns->bdev))
                id->nsfeat |= NVME_NS_ROTATIONAL;
+       /*
+        * We need flush command to flush the file's metadata,
+        * so report supporting vwc if backend is file, even
+        * though buffered_io is disable.
+        */
+       if (req->ns->bdev && !bdev_write_cache(req->ns->bdev))
+               id->nsfeat |= NVME_NS_VWC_NOT_PRESENT;
 
        status = nvmet_copy_to_sgl(req, 0, id, sizeof(*id));
        kfree(id);