]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ASoC: ti: davinci-mcasp:: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 8 Apr 2025 07:38:20 +0000 (09:38 +0200)
committerMark Brown <broonie@kernel.org>
Sun, 13 Apr 2025 19:23:15 +0000 (20:23 +0100)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://patch.msgid.link/20250408-gpiochip-set-rv-sound-v1-2-dd54b6ca1ef9@linaro.org
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/ti/davinci-mcasp.c

index a0b8cca31cba0ba7af5c1fa84909d2ee4ade35c8..caf1887cc9d1c51c5964f224845f14bd0010942f 100644 (file)
@@ -2157,8 +2157,8 @@ static int davinci_mcasp_gpio_direction_out(struct gpio_chip *chip,
        return 0;
 }
 
-static void davinci_mcasp_gpio_set(struct gpio_chip *chip, unsigned offset,
-                                 int value)
+static int davinci_mcasp_gpio_set(struct gpio_chip *chip, unsigned int offset,
+                                int value)
 {
        struct davinci_mcasp *mcasp = gpiochip_get_data(chip);
 
@@ -2166,6 +2166,8 @@ static void davinci_mcasp_gpio_set(struct gpio_chip *chip, unsigned offset,
                mcasp_set_bits(mcasp, DAVINCI_MCASP_PDOUT_REG, BIT(offset));
        else
                mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDOUT_REG, BIT(offset));
+
+       return 0;
 }
 
 static int davinci_mcasp_gpio_direction_in(struct gpio_chip *chip,
@@ -2216,7 +2218,7 @@ static const struct gpio_chip davinci_mcasp_template_chip = {
        .request                = davinci_mcasp_gpio_request,
        .free                   = davinci_mcasp_gpio_free,
        .direction_output       = davinci_mcasp_gpio_direction_out,
-       .set                    = davinci_mcasp_gpio_set,
+       .set_rv                 = davinci_mcasp_gpio_set,
        .direction_input        = davinci_mcasp_gpio_direction_in,
        .get                    = davinci_mcasp_gpio_get,
        .get_direction          = davinci_mcasp_gpio_get_direction,