]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
media: nuvoton: npcm-video: Fix IS_ERR() vs NULL bug
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 27 Sep 2023 12:39:43 +0000 (15:39 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Sat, 7 Oct 2023 08:55:45 +0000 (10:55 +0200)
The of_parse_phandle() function returns NULL on error.  It never returns
error pointers.  Update the check accordingly.

Fixes: 70721089985c ("media: nuvoton: Add driver for NPCM video capture and encoding engine")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/nuvoton/npcm-video.c

index ac8d73b794d37fe37816432b573f233962a3d339..b9e6782f59b420fb6091c09e361fe9a617fa5be4 100644 (file)
@@ -1660,9 +1660,9 @@ static int npcm_video_ece_init(struct npcm_video *video)
        void __iomem *regs;
 
        ece_node = of_parse_phandle(video->dev->of_node, "nuvoton,ece", 0);
-       if (IS_ERR(ece_node)) {
+       if (!ece_node) {
                dev_err(dev, "Failed to get ECE phandle in DTS\n");
-               return PTR_ERR(ece_node);
+               return -ENODEV;
        }
 
        video->ece.enable = of_device_is_available(ece_node);