]> www.infradead.org Git - users/hch/misc.git/commitdiff
phy: renesas: rcar-gen3-usb2: Move debug print after register value is updated
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Fri, 8 Aug 2025 21:52:09 +0000 (22:52 +0100)
committerVinod Koul <vkoul@kernel.org>
Wed, 20 Aug 2025 16:51:52 +0000 (22:21 +0530)
Relocate the debug print in rcar_gen3_enable_vbus_ctrl() to appear after
the `val` variable is assigned and updated based on the VBUS state. This
ensures that the debug log reflects the actual register value being
written, improving debugging accuracy.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20250808215209.3692744-6-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/renesas/phy-rcar-gen3-usb2.c

index 8caef9cb228cea1e555e920f60c949328077073d..7b4a6e8b7508f0f100348cdbb31a663fbf01b0fa 100644 (file)
@@ -211,7 +211,6 @@ static void rcar_gen3_enable_vbus_ctrl(struct rcar_gen3_chan *ch, int vbus)
        u32 vbus_ctrl_val = USB2_ADPCTRL_DRVVBUS;
        u32 val;
 
-       dev_vdbg(ch->dev, "%s: %08x, %d\n", __func__, val, vbus);
        if (ch->phy_data->no_adp_ctrl || ch->phy_data->vblvl_ctrl) {
                if (ch->vbus)
                        regulator_hardware_enable(ch->vbus, vbus);
@@ -225,6 +224,7 @@ static void rcar_gen3_enable_vbus_ctrl(struct rcar_gen3_chan *ch, int vbus)
                val |= vbus_ctrl_val;
        else
                val &= ~vbus_ctrl_val;
+       dev_vdbg(ch->dev, "%s: %08x, %d\n", __func__, val, vbus);
        writel(val, usb2_base + vbus_ctrl_reg);
 }