]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
fbdev: mmp: Use devm_clk_get_enabled() helpers
authorying zuxin <yingzuxin@vivo.com>
Fri, 23 Aug 2024 12:29:57 +0000 (20:29 +0800)
committerHelge Deller <deller@gmx.de>
Fri, 30 Aug 2024 16:42:38 +0000 (18:42 +0200)
The devm_clk_get_enabled() helpers:
    - call devm_clk_get()
    - call clk_prepare_enable() and register what is needed in order to
     call clk_disable_unprepare() when needed, as a managed resource.

This simplifies the code and avoids the calls to clk_disable_unprepare().

Signed-off-by: ying zuxin <yingzuxin@vivo.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/mmp/hw/mmp_ctrl.c

index a20a2c4081274f7d5b6a76d0ffda39bc1cc4f03e..03e23173198ce148f30392074dd9aa53b85e30d3 100644 (file)
@@ -512,16 +512,13 @@ static int mmphw_probe(struct platform_device *pdev)
        }
 
        /* get clock */
-       ctrl->clk = devm_clk_get(ctrl->dev, mi->clk_name);
+       ctrl->clk = devm_clk_get_enabled(ctrl->dev, mi->clk_name);
        if (IS_ERR(ctrl->clk)) {
                ret = PTR_ERR(ctrl->clk);
                dev_err_probe(ctrl->dev, ret,
                              "unable to get clk %s\n", mi->clk_name);
                goto failed;
        }
-       ret = clk_prepare_enable(ctrl->clk);
-       if (ret)
-               goto failed;
 
        /* init global regs */
        ctrl_set_default(ctrl);
@@ -556,7 +553,6 @@ failed_path_init:
                path_deinit(path_plat);
        }
 
-       clk_disable_unprepare(ctrl->clk);
 failed:
        dev_err(&pdev->dev, "device init failed\n");