]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
media: i2c: imx219: Drop IMX219_VTS_* macros
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Sun, 24 Sep 2023 15:33:02 +0000 (18:33 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Sat, 7 Oct 2023 08:55:47 +0000 (10:55 +0200)
The IMX219_VTS_* macros define default VTS values for the modes
supported by the driver. They are used in a single place, and hinder
readability compared to using the value directly as a decimal number.
Drop them.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/i2c/imx219.c

index 82e5d1dad14a75af0c2b009e6b4c4dec9c9fc441..76551e6db22ae24a62c9d9e899aab42dd31cfa47 100644 (file)
 
 /* V_TIMING internal */
 #define IMX219_REG_VTS                 CCI_REG16(0x0160)
-#define IMX219_VTS_15FPS               0x0dc6
-#define IMX219_VTS_30FPS_1080P         0x06e3
-#define IMX219_VTS_30FPS_BINNED                0x06e3
-#define IMX219_VTS_30FPS_640x480       0x06e3
 #define IMX219_VTS_MAX                 0xffff
 
 #define IMX219_VBLANK_MIN              4
@@ -301,7 +297,7 @@ static const struct imx219_mode supported_modes[] = {
                        .width = 3280,
                        .height = 2464
                },
-               .vts_def = IMX219_VTS_15FPS,
+               .vts_def = 3526,
        },
        {
                /* 1080P 30fps cropped */
@@ -313,7 +309,7 @@ static const struct imx219_mode supported_modes[] = {
                        .width = 1920,
                        .height = 1080
                },
-               .vts_def = IMX219_VTS_30FPS_1080P,
+               .vts_def = 1763,
        },
        {
                /* 2x2 binned 30fps mode */
@@ -325,7 +321,7 @@ static const struct imx219_mode supported_modes[] = {
                        .width = 3280,
                        .height = 2464
                },
-               .vts_def = IMX219_VTS_30FPS_BINNED,
+               .vts_def = 1763,
        },
        {
                /* 640x480 30fps mode */
@@ -337,7 +333,7 @@ static const struct imx219_mode supported_modes[] = {
                        .width = 1280,
                        .height = 960
                },
-               .vts_def = IMX219_VTS_30FPS_640x480,
+               .vts_def = 1763,
        },
 };