pinctrl: renesas: Switch to use kmemdup_array()

Let kmemdup_array() take care of multiplication and possible overflow.

Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/20240822061438.14617-1-shenlichuan@vivo.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
index 5e3d735a8570a70c0db894bbca5ce44c464448f7..2a73a8c374b35bcd2ba5bd32a850551253ed69a3 100644 (file)
--- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
@@ -528,8 +528,7 @@ static int rzg2l_map_add_config(struct pinctrl_map *map,
 {
        unsigned long *cfgs;
 
-       cfgs = kmemdup(configs, num_configs * sizeof(*cfgs),
-                      GFP_KERNEL);
+       cfgs = kmemdup_array(configs, num_configs, sizeof(*cfgs), GFP_KERNEL);
        if (!cfgs)
                return -ENOMEM;
 

diff --git a/drivers/pinctrl/renesas/pinctrl-rzv2m.c b/drivers/pinctrl/renesas/pinctrl-rzv2m.c
index 0cae5472ac678c012c7eda504f1105129402735e..4062c56619f595017091e6682689bfdf9ad4964f 100644 (file)
--- a/drivers/pinctrl/renesas/pinctrl-rzv2m.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzv2m.c
@@ -196,8 +196,7 @@ static int rzv2m_map_add_config(struct pinctrl_map *map,
 {
        unsigned long *cfgs;
 
-       cfgs = kmemdup(configs, num_configs * sizeof(*cfgs),
-                      GFP_KERNEL);
+       cfgs = kmemdup_array(configs, num_configs, sizeof(*cfgs), GFP_KERNEL);
        if (!cfgs)
                return -ENOMEM;
 

diff --git a/drivers/pinctrl/renesas/pinctrl.c b/drivers/pinctrl/renesas/pinctrl.c
index 03e9bdbc82b9099bc40ff51adbcb9bf30a829952..29d16c9c1bd194abaf8708cbc4199a6be9ed45e4 100644 (file)
--- a/drivers/pinctrl/renesas/pinctrl.c
+++ b/drivers/pinctrl/renesas/pinctrl.c
@@ -83,8 +83,7 @@ static int sh_pfc_map_add_config(struct pinctrl_map *map,
 {
        unsigned long *cfgs;
 
-       cfgs = kmemdup(configs, num_configs * sizeof(*cfgs),
-                      GFP_KERNEL);
+       cfgs = kmemdup_array(configs, num_configs, sizeof(*cfgs), GFP_KERNEL);
        if (cfgs == NULL)
                return -ENOMEM;