HID: playstation: fix DualShock4 unreachable calibration code.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Reported-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c
index f399bf0d3c8cc33d117d0b060960e611619acc3c..866cc4e94320f2ca4ae0611f0348a176a61d9be9 100644 (file)
--- a/drivers/hid/hid-playstation.c
+++ b/drivers/hid/hid-playstation.c
@@ -1759,11 +1759,10 @@ static int dualshock4_get_calibration_data(struct dualshock4 *ds4)
                                if (retries < 2) {
                                        hid_warn(hdev, "Retrying DualShock 4 get calibration report (0x02) request\n");
                                        continue;
-                               } else {
-                                       ret = -EILSEQ;
-                                       goto err_free;
                                }
+
                                hid_err(hdev, "Failed to retrieve DualShock4 calibration info: %d\n", ret);
+                               ret = -EILSEQ;
                                goto err_free;
                        } else {
                                break;