]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
hw/loongarch/boot.c: fix out-of-bound reading
authorDmitry Frolov <frolov@swemel.ru>
Fri, 28 Jun 2024 12:39:10 +0000 (15:39 +0300)
committerSong Gao <gaosong@loongson.cn>
Fri, 12 Jul 2024 01:41:18 +0000 (09:41 +0800)
memcpy() is trying to READ 512 bytes from memory,
pointed by info->kernel_cmdline,
which was (presumable) allocated by g_strdup("");
Found with ASAN, making check with enabled sanitizers.

Signed-off-by: Dmitry Frolov <frolov@swemel.ru>
Reviewed-by: Song Gao <gaosong@loongson.cn>
Message-Id: <20240628123910.577740-1-frolov@swemel.ru>
Signed-off-by: Song Gao <gaosong@loongson.cn>
hw/loongarch/boot.c

index b8e1aa18d5b0d78b0a661407689070ff787dc8bc..cb668703bddd03c6beef87b401112df14f9cf36b 100644 (file)
@@ -163,7 +163,7 @@ static void init_cmdline(struct loongarch_boot_info *info, void *p, void *start)
     info->a0 = 1;
     info->a1 = cmdline_addr;
 
-    memcpy(p, info->kernel_cmdline, COMMAND_LINE_SIZE);
+    g_strlcpy(p, info->kernel_cmdline, COMMAND_LINE_SIZE);
 }
 
 static uint64_t cpu_loongarch_virt_to_phys(void *opaque, uint64_t addr)