staging: wilc1000: refactor wilc_set_operation_mode() to avoid deferred handling

Avoid handling of WID_CURRENT_CHANNEL wid command in deferred approach.
Instead of posting the wid to work queue now handle directly from the
caller context. Use structure to fill in the firmware specific format.

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 1910f9a77996864d9bd35f8d617dfa47143d25dd..312c01e31ab3f854e83278181901cadeb0a575c8 100644 (file)
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -85,6 +85,10 @@ struct del_all_sta {
        u8 mac[WILC_MAX_NUM_STA][ETH_ALEN];
 };
 
+struct wilc_op_mode {
+       __le32 mode;
+};
+
 struct wilc_reg_frame {
        bool reg;
        u8 reg_id;
@@ -111,7 +115,6 @@ union message_body {
        struct set_ip_addr ip_info;
        struct drv_handler drv;
        struct set_multicast multicast_info;
-       struct op_mode mode;
        struct get_mac_addr get_mac_info;
        struct ba_session_info session_info;
        struct remain_ch remain_on_ch;
@@ -261,28 +264,6 @@ free_msg:
        kfree(msg);
 }
 
-static void handle_set_operation_mode(struct work_struct *work)
-{
-       struct host_if_msg *msg = container_of(work, struct host_if_msg, work);
-       struct wilc_vif *vif = msg->vif;
-       struct op_mode *hif_op_mode = &msg->body.mode;
-       int ret;
-       struct wid wid;
-
-       wid.id = WID_SET_OPERATION_MODE;
-       wid.type = WID_INT;
-       wid.val = (s8 *)&hif_op_mode->mode;
-       wid.size = sizeof(u32);
-
-       ret = wilc_send_config_pkt(vif, WILC_SET_CFG, &wid, 1,
-                                  wilc_get_vif_idx(vif));
-
-       if (ret)
-               netdev_err(vif->ndev, "Failed to set operation mode\n");
-
-       kfree(msg);
-}
-
 static void handle_get_mac_address(struct work_struct *work)
 {
        struct host_if_msg *msg = container_of(work, struct host_if_msg, work);
@@ -2550,19 +2531,21 @@ int wilc_set_wfi_drv_handler(struct wilc_vif *vif, int index, u8 mode,
 
 int wilc_set_operation_mode(struct wilc_vif *vif, u32 mode)
 {
+       struct wid wid;
+       struct wilc_op_mode op_mode;
        int result;
-       struct host_if_msg *msg;
 
-       msg  = wilc_alloc_work(vif, handle_set_operation_mode, false);
-       if (IS_ERR(msg))
-               return PTR_ERR(msg);
+       wid.id = WID_SET_OPERATION_MODE;
+       wid.type = WID_INT;
+       wid.size = sizeof(op_mode);
+       wid.val = (u8 *)&op_mode;
 
-       msg->body.mode.mode = mode;
-       result = wilc_enqueue_work(msg);
-       if (result) {
-               netdev_err(vif->ndev, "%s: enqueue work failed\n", __func__);
-               kfree(msg);
-       }
+       op_mode.mode = cpu_to_le32(mode);
+
+       result = wilc_send_config_pkt(vif, WILC_SET_CFG, &wid, 1,
+                                     wilc_get_vif_idx(vif));
+       if (result)
+               netdev_err(vif->ndev, "Failed to set operation mode\n");
 
        return result;
 }

diff --git a/drivers/staging/wilc1000/host_interface.h b/drivers/staging/wilc1000/host_interface.h
index 10d5627b22bf22df7ebbbb22b58b2c0159376143..e9583574ed245c65f3cdf5e4b269ab4466a8f2ed 100644 (file)
--- a/drivers/staging/wilc1000/host_interface.h
+++ b/drivers/staging/wilc1000/host_interface.h
@@ -220,10 +220,6 @@ struct drv_handler {
        u8 name;
 };
 
-struct op_mode {
-       u32 mode;
-};
-
 struct get_mac_addr {
        u8 *mac_addr;
 };