ARM: EXYNOS: handle properly the return values

The cpuidle_register_driver return value is not checked.
The init function returns always -EIO when cpuidle_register_device
fails but the error could be different.

This patch fixes that by checking the cpuidle_register_driver properly
and returning the correct value when cpuidle_register_device fails.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>

diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c
index 6ac4069f3c93279f50f0c6947b81d84b2d8e19cc..a4e50811c9c50f8ca89290062031aee7951a9fb2 100644 (file)
--- a/arch/arm/mach-exynos/cpuidle.c
+++ b/arch/arm/mach-exynos/cpuidle.c
@@ -194,13 +194,17 @@ static void __init exynos5_core_down_clk(void)
 
 static int __init exynos4_init_cpuidle(void)
 {
-       int cpu_id;
+       int cpu_id, ret;
        struct cpuidle_device *device;
 
        if (soc_is_exynos5250())
                exynos5_core_down_clk();
 
-       cpuidle_register_driver(&exynos4_idle_driver);
+       ret = cpuidle_register_driver(&exynos4_idle_driver);
+       if (ret) {
+               printk(KERN_ERR "CPUidle failed to register driver\n");
+               return ret;
+       }
 
        for_each_cpu(cpu_id, cpu_online_mask) {
                device = &per_cpu(exynos4_cpuidle_device, cpu_id);
@@ -210,9 +214,10 @@ static int __init exynos4_init_cpuidle(void)
                if (cpu_id != 0)
                        device->state_count = 1;
 
-               if (cpuidle_register_device(device)) {
-                       printk(KERN_ERR "CPUidle register device failed\n,");
-                       return -EIO;
+               ret = cpuidle_register_device(device);
+               if (ret) {
+                       printk(KERN_ERR "CPUidle register device failed\n");
+                       return ret;
                }
        }