Drivers: hv: avoid passing opaque pointer to vmbus_onmessage()

vmbus_onmessage() doesn't need the header of the message, it only
uses it to get to the payload, we can pass the pointer to the
payload directly.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Link: https://lore.kernel.org/r/20200406104154.45010-4-vkuznets@redhat.com
Signed-off-by: Wei Liu <wei.liu@kernel.org>

diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
index 501c43c5851dcc503edaff6c19cfc5b0d4df4a66..da93b5f1b143667f0097171a4f4c3d719d5d3aa4 100644 (file)
--- a/drivers/hv/channel_mgmt.c
+++ b/drivers/hv/channel_mgmt.c
@@ -1363,13 +1363,8 @@ channel_message_table[CHANNELMSG_COUNT] = {
  *
  * This is invoked in the vmbus worker thread context.
  */
-void vmbus_onmessage(void *context)
+void vmbus_onmessage(struct vmbus_channel_message_header *hdr)
 {
-       struct hv_message *msg = context;
-       struct vmbus_channel_message_header *hdr;
-
-       hdr = (struct vmbus_channel_message_header *)msg->u.payload;
-
        trace_vmbus_on_message(hdr);
 
        /*

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index e356ea4752c0f4a7e2110b99bc7b4969c3300935..8f08e8273dd8f48f018159a8d2e4d6739f7cd9ec 100644 (file)
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -1035,7 +1035,8 @@ static void vmbus_onmessage_work(struct work_struct *work)
 
        ctx = container_of(work, struct onmessage_work_context,
                           work);
-       vmbus_onmessage(&ctx->msg);
+       vmbus_onmessage((struct vmbus_channel_message_header *)
+                       &ctx->msg.payload);
        kfree(ctx);
 }
 

diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 692c89ccf5dfd755ee7d8f0f5605caf7c63dd3cf..cbd24f4e68d15a8c8585c9346857196f65f07858 100644 (file)
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -1017,7 +1017,7 @@ static inline void clear_low_latency_mode(struct vmbus_channel *c)
        c->low_latency = false;
 }
 
-void vmbus_onmessage(void *context);
+void vmbus_onmessage(struct vmbus_channel_message_header *hdr);
 
 int vmbus_request_offers(void);