]> www.infradead.org Git - users/hch/misc.git/commitdiff
HID: i2c-hid: Fix test in i2c_hid_core_register_panel_follower()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 27 Aug 2025 12:57:31 +0000 (15:57 +0300)
committerDouglas Anderson <dianders@chromium.org>
Wed, 27 Aug 2025 23:35:20 +0000 (16:35 -0700)
Bitwise AND was intended instead of OR.  With the current code the
condition is always true.

Fixes: cbdd16b818ee ("HID: i2c-hid: Make elan touch controllers power on after panel is enabled")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Pin-yen Lin <treapking@chromium.org>
Acked-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/aK8Au3CgZSTvfEJ6@stanley.mountain
drivers/hid/i2c-hid/i2c-hid-core.c

index 99ce6386176c681dc55fbd6e27dc5eb377732202..30ebde1273be33a3db676ec1749e61c1db1b4959 100644 (file)
@@ -1189,7 +1189,7 @@ static int i2c_hid_core_register_panel_follower(struct i2c_hid *ihid)
        struct device *dev = &ihid->client->dev;
        int ret;
 
-       if (ihid->hid->initial_quirks | HID_QUIRK_POWER_ON_AFTER_BACKLIGHT)
+       if (ihid->hid->initial_quirks & HID_QUIRK_POWER_ON_AFTER_BACKLIGHT)
                ihid->panel_follower.funcs = &i2c_hid_core_panel_follower_enable_funcs;
        else
                ihid->panel_follower.funcs = &i2c_hid_core_panel_follower_prepare_funcs;