drbd: drbd_send_ov_request(): Return 0 upon success and an error code otherwise

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index 47771ab82579653359b45f955165f66c898ba365..200791e44aa257c6c065c5dbd65b8ba75ec63ae5 100644 (file)
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -1342,15 +1342,13 @@ int drbd_send_drequest_csum(struct drbd_conf *mdev, sector_t sector, int size,
 
 int drbd_send_ov_request(struct drbd_conf *mdev, sector_t sector, int size)
 {
-       int ok;
        struct p_block_req p;
 
        p.sector   = cpu_to_be64(sector);
        p.block_id = ID_SYNCER /* unused */;
        p.blksize  = cpu_to_be32(size);
 
-       ok = !drbd_send_cmd(mdev, &mdev->tconn->data, P_OV_REQUEST, &p.head, sizeof(p));
-       return ok;
+       return drbd_send_cmd(mdev, &mdev->tconn->data, P_OV_REQUEST, &p.head, sizeof(p));
 }
 
 /* called on sndtimeo

diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c
index 9b740864b51c8a20e475e223f37cff925d69b990..216479641a787ecc6343acc490be7199d3a090d6 100644 (file)
--- a/drivers/block/drbd/drbd_worker.c
+++ b/drivers/block/drbd/drbd_worker.c
@@ -695,7 +695,7 @@ static int w_make_ov_request(struct drbd_work *w, int cancel)
                        size = (capacity-sector)<<9;
 
                inc_rs_pending(mdev);
-               if (!drbd_send_ov_request(mdev, sector, size)) {
+               if (drbd_send_ov_request(mdev, sector, size)) {
                        dec_rs_pending(mdev);
                        return 0;
                }