]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
drm/xe/display: move display fini stuff to devm
authorMatthew Auld <matthew.auld@intel.com>
Wed, 22 May 2024 10:21:59 +0000 (11:21 +0100)
committerMatthew Auld <matthew.auld@intel.com>
Wed, 22 May 2024 12:22:40 +0000 (13:22 +0100)
Match the i915 display handling here with calling both no_irq and
noaccel when removing the device.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240522102143.128069-34-matthew.auld@intel.com
drivers/gpu/drm/xe/display/xe_display.c

index 63b27fbcdaca36baad7f7f24238ba239ca389b7f..89701ca841fc29798a763780ffc89b8713d31327 100644 (file)
@@ -135,9 +135,9 @@ int xe_display_init_nommio(struct xe_device *xe)
        return drmm_add_action_or_reset(&xe->drm, xe_display_fini_nommio, xe);
 }
 
-static void xe_display_fini_noirq(struct drm_device *dev, void *dummy)
+static void xe_display_fini_noirq(void *arg)
 {
-       struct xe_device *xe = to_xe_device(dev);
+       struct xe_device *xe = arg;
 
        if (!xe->info.enable_display)
                return;
@@ -172,12 +172,12 @@ int xe_display_init_noirq(struct xe_device *xe)
        if (err)
                return err;
 
-       return drmm_add_action_or_reset(&xe->drm, xe_display_fini_noirq, NULL);
+       return devm_add_action_or_reset(xe->drm.dev, xe_display_fini_noirq, xe);
 }
 
-static void xe_display_fini_noaccel(struct drm_device *dev, void *dummy)
+static void xe_display_fini_noaccel(void *arg)
 {
-       struct xe_device *xe = to_xe_device(dev);
+       struct xe_device *xe = arg;
 
        if (!xe->info.enable_display)
                return;
@@ -196,7 +196,7 @@ int xe_display_init_noaccel(struct xe_device *xe)
        if (err)
                return err;
 
-       return drmm_add_action_or_reset(&xe->drm, xe_display_fini_noaccel, NULL);
+       return devm_add_action_or_reset(xe->drm.dev, xe_display_fini_noaccel, xe);
 }
 
 int xe_display_init(struct xe_device *xe)