]> www.infradead.org Git - users/mchehab/rasdaemon.git/commitdiff
rasdaemon: Fix "ignoring return value" build warning.
authorYazen Ghannam <yazen.ghannam@amd.com>
Fri, 8 May 2020 14:51:29 +0000 (14:51 +0000)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 21 Jul 2020 12:48:05 +0000 (14:48 +0200)
The following build warning is given:

ras-diskerror-handler.c: In function ras_diskerror_event_handler:
ras-diskerror-handler.c:98:2:
warning: ignoring return value of asprintf, declared with attribute warn_unused_result [-Wunused-result]
  asprintf(&ev.dev, "%u:%u", major(dev), minor(dev));
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check the return value of asprintf() to avoid the warning.

Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
ras-diskerror-handler.c

index 68c0c77548f6a6e0c0e98ac6c5c1f77534fcb9a8..b16319f3f974ea2dbdb38a303825d249946fd526 100644 (file)
@@ -95,7 +95,8 @@ int ras_diskerror_event_handler(struct trace_seq *s,
        if (pevent_get_field_val(s, event, "dev", record, &val, 1) < 0)
                return -1;
        dev = (dev_t)val;
-       asprintf(&ev.dev, "%u:%u", major(dev), minor(dev));
+       if (asprintf(&ev.dev, "%u:%u", major(dev), minor(dev)) < 0)
+               return -1;
 
        if (pevent_get_field_val(s, event, "sector", record, &val, 1) < 0)
                return -1;