drm/msm/adreno/a5xx_debugfs: fix potential NULL pointer dereference

_minor_ is being dereferenced before it is null checked, hence there
is a potential null pointer dereference. Fix this by moving the pointer
dereference after _minor_ has been null checked.

Fixes: 024ad8df763f ("drm/msm: add a5xx specific debugfs")
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Rob Clark <robdclark@gmail.com>

diff --git a/drivers/gpu/drm/msm/adreno/a5xx_debugfs.c b/drivers/gpu/drm/msm/adreno/a5xx_debugfs.c
index 6b279414b9c0d1e5a08cb4a6da02975c23de0086..059ec7d394d0e799287d6f64902d00ae165d2b2a 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a5xx_debugfs.c
+++ b/drivers/gpu/drm/msm/adreno/a5xx_debugfs.c
@@ -159,13 +159,15 @@ DEFINE_SIMPLE_ATTRIBUTE(reset_fops, NULL, reset_set, "%llx\n");
 
 int a5xx_debugfs_init(struct msm_gpu *gpu, struct drm_minor *minor)
 {
-       struct drm_device *dev = minor->dev;
+       struct drm_device *dev;
        struct dentry *ent;
        int ret;
 
        if (!minor)
                return 0;
 
+       dev = minor->dev;
+
        ret = drm_debugfs_create_files(a5xx_debugfs_list,
                        ARRAY_SIZE(a5xx_debugfs_list),
                        minor->debugfs_root, minor);