]> www.infradead.org Git - users/hch/xfs.git/commitdiff
vfio/pci: Init the count variable in collecting hot-reset devices
authorYi Liu <yi.l.liu@intel.com>
Wed, 10 Jul 2024 00:41:50 +0000 (17:41 -0700)
committerAlex Williamson <alex.williamson@redhat.com>
Wed, 10 Jul 2024 14:47:46 +0000 (08:47 -0600)
The count variable is used without initialization, it results in mistakes
in the device counting and crashes the userspace if the get hot reset info
path is triggered.

Fixes: f6944d4a0b87 ("vfio/pci: Collect hot-reset devices to local buffer")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=219010
Reported-by: Žilvinas Žaltiena <zaltys@natrix.lt>
Cc: Beld Zhang <beldzhang@gmail.com>
Signed-off-by: Yi Liu <yi.l.liu@intel.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20240710004150.319105-1-yi.l.liu@intel.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/vfio/pci/vfio_pci_core.c

index 987c7921affa6883232ed2f19eb23ca459c43fd1..ba0ce0075b2fb164a5b8ac7d4aa07a53d2b4beb6 100644 (file)
@@ -1260,7 +1260,7 @@ static int vfio_pci_ioctl_get_pci_hot_reset_info(
        struct vfio_pci_hot_reset_info hdr;
        struct vfio_pci_fill_info fill = {};
        bool slot = false;
-       int ret, count;
+       int ret, count = 0;
 
        if (copy_from_user(&hdr, arg, minsz))
                return -EFAULT;