lib/lru_cache: fix error free handing in lc_create

When kmem_cache_alloc in function lc_create returns null, we will
free the memory already allocated. The loop of kmem_cache_free
is wrong, especially:
  i = 0  ==> do wrong loop
  i > 0  ==> do not free element[0]

Link: https://lkml.kernel.org/r/20220618082521.7082-1-wuchi.zero@gmail.com
Signed-off-by: wuchi <wuchi.zero@gmail.com>
Cc: Philipp Reisner <philipp.reisner@linbit.com>
Cc: Lars Ellenberg <lars.ellenberg@linbit.com>
Cc: Christoph Bhmwalder <christoph.boehmwalder@linbit.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/lib/lru_cache.c b/lib/lru_cache.c
index 52313acbfa6284a57909ec8967e1abac0a24259b..dc35464216d3ccb0340ba747e5c3ef64620b51a4 100644 (file)
--- a/lib/lru_cache.c
+++ b/lib/lru_cache.c
@@ -147,8 +147,8 @@ struct lru_cache *lc_create(const char *name, struct kmem_cache *cache,
                return lc;
 
        /* else: could not allocate all elements, give up */
-       for (i--; i; i--) {
-               void *p = element[i];
+       while (i) {
+               void *p = element[--i];
                kmem_cache_free(cache, p - e_off);
        }
        kfree(lc);