drm/amdgpu: remove redundant NULL check

release_firmware() checks whether firmware pointer is NULL.
Remove the redundant NULL check in psp_sw_fini().

Signed-off-by: Yushan Zhou <katrinzhou@tencent.com>
Reviewed-by: Luben Tuikov <luben.tuikov@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index fe1638532ab85214485a301beb6a12439a4848ba..5f6c002aa0c88127b1649349b71874a129ea074c 100644 (file)
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -513,26 +513,22 @@ static int psp_sw_fini(void *handle)
        struct psp_gfx_cmd_resp *cmd = psp->cmd;
 
        psp_memory_training_fini(psp);
-       if (psp->sos_fw) {
-               release_firmware(psp->sos_fw);
-               psp->sos_fw = NULL;
-       }
-       if (psp->asd_fw) {
-               release_firmware(psp->asd_fw);
-               psp->asd_fw = NULL;
-       }
-       if (psp->ta_fw) {
-               release_firmware(psp->ta_fw);
-               psp->ta_fw = NULL;
-       }
-       if (psp->cap_fw) {
-               release_firmware(psp->cap_fw);
-               psp->cap_fw = NULL;
-       }
-       if (psp->toc_fw) {
-               release_firmware(psp->toc_fw);
-               psp->toc_fw = NULL;
-       }
+
+       release_firmware(psp->sos_fw);
+       psp->sos_fw = NULL;
+
+       release_firmware(psp->asd_fw);
+       psp->asd_fw = NULL;
+
+       release_firmware(psp->ta_fw);
+       psp->ta_fw = NULL;
+
+       release_firmware(psp->cap_fw);
+       psp->cap_fw = NULL;
+
+       release_firmware(psp->toc_fw);
+       psp->toc_fw = NULL;
+
        if (adev->ip_versions[MP0_HWIP][0] == IP_VERSION(11, 0, 0) ||
            adev->ip_versions[MP0_HWIP][0] == IP_VERSION(11, 0, 7))
                psp_sysfs_fini(adev);