]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net: mvneta: fix locking in mvneta_cpu_online()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Tue, 21 Jan 2025 00:50:02 +0000 (16:50 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 23 Jan 2025 15:02:29 +0000 (07:02 -0800)
When port is stopped, unlock before returning

Fixes: 413f0271f396 ("net: protect NAPI enablement with netdev_lock()")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250121005002.3938236-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/mvneta.c

index 82f4333fb426c6941a6cf56350c1f1327f066cdc..4fe121b9f94b6ee4e2b670155858a817e52505fa 100644 (file)
@@ -4432,6 +4432,7 @@ static int mvneta_cpu_online(unsigned int cpu, struct hlist_node *node)
         */
        if (pp->is_stopped) {
                spin_unlock(&pp->lock);
+               netdev_unlock(port->napi.dev);
                return 0;
        }
        netif_tx_stop_all_queues(pp->dev);