]> www.infradead.org Git - users/hch/misc.git/commitdiff
ARM: module: Use RCU in all users of __module_text_address().
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Wed, 8 Jan 2025 09:04:45 +0000 (10:04 +0100)
committerPetr Pavlu <petr.pavlu@suse.com>
Mon, 10 Mar 2025 10:54:45 +0000 (11:54 +0100)
__module_text_address() can be invoked within a RCU section, there is no
requirement to have preemption disabled.

Replace the preempt_disable() section around __module_text_address()
with RCU.

Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250108090457.512198-17-bigeasy@linutronix.de
Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
arch/arm/kernel/module-plts.c

index da2ee8d6ef1a7bb352b3803ebf5828fa48419105..354ce16d83cb5ac1734af9bf0eff1f7f8e15f9f4 100644 (file)
@@ -285,11 +285,9 @@ bool in_module_plt(unsigned long loc)
        struct module *mod;
        bool ret;
 
-       preempt_disable();
+       guard(rcu)();
        mod = __module_text_address(loc);
        ret = mod && (loc - (u32)mod->arch.core.plt_ent < mod->arch.core.plt_count * PLT_ENT_SIZE ||
                      loc - (u32)mod->arch.init.plt_ent < mod->arch.init.plt_count * PLT_ENT_SIZE);
-       preempt_enable();
-
        return ret;
 }