]> www.infradead.org Git - users/hch/block.git/commitdiff
block: use kstrtoul in flag_store
authorChristoph Hellwig <hch@lst.de>
Mon, 3 Jun 2024 08:24:18 +0000 (10:24 +0200)
committerChristoph Hellwig <hch@lst.de>
Thu, 6 Jun 2024 09:41:38 +0000 (11:41 +0200)
Use the text to integer helper that has error handling and doesn't modify
the input pointer.

Signed-off-by: Christoph Hellwig <hch@lst.de>
block/blk-integrity.c

index 686b6adf0ea5c7a65e5dfd59b5528427ca7cd58c..bb3cd1e0eeb58e8dec4fa1f589832f1cc727d85e 100644 (file)
@@ -245,8 +245,12 @@ static ssize_t flag_store(struct device *dev, struct device_attribute *attr,
                const char *page, size_t count, unsigned char flag)
 {
        struct blk_integrity *bi = dev_to_bi(dev);
-       char *p = (char *) page;
-       unsigned long val = simple_strtoul(p, &p, 10);
+       unsigned long val;
+       int err;
+
+       err = kstrtoul(page, 10, &val);
+       if (err)
+               return err;
 
        if (val)
                bi->flags |= flag;