]> www.infradead.org Git - linux-platform-drivers-x86.git/commitdiff
platform/x86: ideapad-laptop: Add platform support for Ideapad 5 Pro 16ACH6-82L5
authorKelly Anderson <kelly@xilka.com>
Sun, 26 Sep 2021 04:39:00 +0000 (22:39 -0600)
committerHans de Goede <hdegoede@redhat.com>
Tue, 28 Sep 2021 14:59:36 +0000 (16:59 +0200)
Adding support specifically for Ideapad 5 Pro 16ACH6-82L5 by adding a
allow list that can validate notebooks for which dytc_version
is less than 5, and seem to work fine at dytc_version 4. This code has
been tested to work properly on the specified system.

Signed-off-by: Kelly Anderson <kelly@xilka.com>
Link: https://lore.kernel.org/r/11840239.O9o76ZdvQC@comer.internal
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/ideapad-laptop.c

index e7a1299e3776668cce588c2595aa34ac9c9f0fc9..2771a05ea5e2c476c20cdb24f04a9fbb37a60b6f 100644 (file)
@@ -868,6 +868,18 @@ static void dytc_profile_refresh(struct ideapad_private *priv)
        }
 }
 
+static const struct dmi_system_id ideapad_dytc_v4_allow_table[] = {
+       {
+               /* Ideapad 5 Pro 16ACH6 */
+               .ident = "LENOVO 82L5",
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "82L5")
+               }
+       },
+       {}
+};
+
 static int ideapad_dytc_profile_init(struct ideapad_private *priv)
 {
        int err, dytc_version;
@@ -882,12 +894,21 @@ static int ideapad_dytc_profile_init(struct ideapad_private *priv)
                return err;
 
        /* Check DYTC is enabled and supports mode setting */
-       if (!test_bit(DYTC_QUERY_ENABLE_BIT, &output))
+       if (!test_bit(DYTC_QUERY_ENABLE_BIT, &output)) {
+               dev_info(&priv->platform_device->dev, "DYTC_QUERY_ENABLE_BIT returned false\n");
                return -ENODEV;
+       }
 
        dytc_version = (output >> DYTC_QUERY_REV_BIT) & 0xF;
-       if (dytc_version < 5)
-               return -ENODEV;
+
+       if (dytc_version < 5) {
+               if (dytc_version < 4 || !dmi_check_system(ideapad_dytc_v4_allow_table)) {
+                       dev_info(&priv->platform_device->dev,
+                                "DYTC_VERSION is less than 4 or is not allowed: %d\n",
+                                dytc_version);
+                       return -ENODEV;
+               }
+       }
 
        priv->dytc = kzalloc(sizeof(*priv->dytc), GFP_KERNEL);
        if (!priv->dytc)