]> www.infradead.org Git - linux.git/commitdiff
pwm: adp5585: Set OSC_EN bit to 1 when PWM state is enabled
authorLiu Ying <victor.liu@nxp.com>
Mon, 26 Aug 2024 08:33:37 +0000 (16:33 +0800)
committerUwe Kleine-König <ukleinek@kernel.org>
Mon, 16 Sep 2024 13:24:58 +0000 (15:24 +0200)
It turns out that OSC_EN bit in GERNERAL_CFG register has to be set to 1
when PWM state is enabled, otherwise PWM signal won't be generated.

Fixes: e9b503879fd2 ("pwm: adp5585: Add Analog Devices ADP5585 support")
Signed-off-by: Liu Ying <victor.liu@nxp.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/20240826083337.1835405-1-victor.liu@nxp.com
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
drivers/pwm/pwm-adp5585.c

index ed7e8c6bcf324cedac020cbb1897d1fcc79459dc..40472ac5db6410a33e4f790fe8e6c23b517502be 100644 (file)
@@ -100,6 +100,10 @@ static int pwm_adp5585_apply(struct pwm_chip *chip,
        if (ret)
                return ret;
 
+       ret = regmap_set_bits(regmap, ADP5585_GENERAL_CFG, ADP5585_OSC_EN);
+       if (ret)
+               return ret;
+
        return regmap_set_bits(regmap, ADP5585_PWM_CFG, ADP5585_PWM_EN);
 }