reset: ti_syscon: fix a ti_syscon_reset_status issue

If STATUS_SET was not set, ti_syscon_reset_status would always return 0
no matter whether the status_bit was set or not.

Signed-off-by: Jiancheng Xue <xuejiancheng@hisilicon.com>
Fixes: cc7c2bb1493c ("reset: add TI SYSCON based reset driver")
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

diff --git a/drivers/reset/reset-ti-syscon.c b/drivers/reset/reset-ti-syscon.c
index 47f0ffd3b0138ba59d3388108cb6ec79dcc61b8f..1799fd423901de52f689886acbd2bacb177ac99d 100644 (file)
--- a/drivers/reset/reset-ti-syscon.c
+++ b/drivers/reset/reset-ti-syscon.c
@@ -154,8 +154,8 @@ static int ti_syscon_reset_status(struct reset_controller_dev *rcdev,
        if (ret)
                return ret;
 
-       return (reset_state & BIT(control->status_bit)) &&
-                       (control->flags & STATUS_SET);
+       return !(reset_state & BIT(control->status_bit)) ==
+               !(control->flags & STATUS_SET);
 }
 
 static struct reset_control_ops ti_syscon_reset_ops = {