]> www.infradead.org Git - users/hch/misc.git/commitdiff
accel/amdxdna: Delete pci_free_irq_vectors()
authorSalah Triki <salah.triki@gmail.com>
Sat, 19 Jul 2025 06:33:36 +0000 (07:33 +0100)
committerLizhi Hou <lizhi.hou@amd.com>
Tue, 22 Jul 2025 16:19:04 +0000 (09:19 -0700)
The device is managed so pci_free_irq_vectors() is called automatically
no need to do it manually.

Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Signed-off-by: Salah Triki <salah.triki@gmail.com>
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Link: https://lore.kernel.org/r/aHs8QAfUlFeNp7qL@pc
drivers/accel/amdxdna/aie2_pci.c

index c6cf7068d23c030fbc2043c875ee2dca32d3b89b..3474a8d4e560de0989354106ca5a7b4a3c65d125 100644 (file)
@@ -520,14 +520,14 @@ static int aie2_init(struct amdxdna_dev *xdna)
        if (!ndev->psp_hdl) {
                XDNA_ERR(xdna, "failed to create psp");
                ret = -ENOMEM;
-               goto free_irq;
+               goto release_fw;
        }
        xdna->dev_handle = ndev;
 
        ret = aie2_hw_start(xdna);
        if (ret) {
                XDNA_ERR(xdna, "start npu failed, ret %d", ret);
-               goto free_irq;
+               goto release_fw;
        }
 
        ret = aie2_mgmt_fw_query(ndev);
@@ -578,8 +578,6 @@ async_event_free:
        aie2_error_async_events_free(ndev);
 stop_hw:
        aie2_hw_stop(xdna);
-free_irq:
-       pci_free_irq_vectors(pdev);
 release_fw:
        release_firmware(fw);
 
@@ -588,12 +586,10 @@ release_fw:
 
 static void aie2_fini(struct amdxdna_dev *xdna)
 {
-       struct pci_dev *pdev = to_pci_dev(xdna->ddev.dev);
        struct amdxdna_dev_hdl *ndev = xdna->dev_handle;
 
        aie2_hw_stop(xdna);
        aie2_error_async_events_free(ndev);
-       pci_free_irq_vectors(pdev);
 }
 
 static int aie2_get_aie_status(struct amdxdna_client *client,