firmware: microchip: fix incorrect error report of programming:timeout on success

After successfully programming the SPI flash with an MFPS auto update
image, the error sysfs attribute reports programming:timeout.
This is caused by an incorrect check on the return value from
wait_for_completion_timeout() in mpfs_auto_update_poll_complete().

Fixes: ec5b0f1193ad ("firmware: microchip: add PolarFire SoC Auto Update support")
Signed-off-by: Steve Wilkins <steve.wilkins@raymarine.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>

diff --git a/drivers/firmware/microchip/mpfs-auto-update.c b/drivers/firmware/microchip/mpfs-auto-update.c
index 30de47895b1ce746e1d8871c5c805b821435fb1a..9ca5ee58edbdf8922a30f2ddbc48baf8d6e74945 100644 (file)
--- a/drivers/firmware/microchip/mpfs-auto-update.c
+++ b/drivers/firmware/microchip/mpfs-auto-update.c
@@ -166,7 +166,7 @@ static enum fw_upload_err mpfs_auto_update_poll_complete(struct fw_upload *fw_up
         */
        ret = wait_for_completion_timeout(&priv->programming_complete,
                                          msecs_to_jiffies(AUTO_UPDATE_TIMEOUT_MS));
-       if (ret)
+       if (!ret)
                return FW_UPLOAD_ERR_TIMEOUT;
 
        return FW_UPLOAD_ERR_NONE;