]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
platform/x86:intel/pmc: Use DEFINE_SHOW_STORE_ATTRIBUTE macro
authorXi Pardee <xi.pardee@linux.intel.com>
Mon, 24 Jun 2024 20:32:16 +0000 (13:32 -0700)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Mon, 8 Jul 2024 07:43:52 +0000 (10:43 +0300)
DEFINE_SHOW_STORE_ATTRIBUTE() macro can be used for the ltr_ignore
attribute for better readability.

Signed-off-by: Xi Pardee <xi.pardee@linux.intel.com>
Link: https://lore.kernel.org/r/20240624203218.2428475-8-xi.pardee@linux.intel.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/intel/pmc/core.c

index 89db5b1a6551e25f118dec54d21f8b221167f30c..41ffc18087eb692cb0441caaecf8864890fa4725 100644 (file)
@@ -529,19 +529,7 @@ static int pmc_core_ltr_ignore_show(struct seq_file *s, void *unused)
 {
        return 0;
 }
-
-static int pmc_core_ltr_ignore_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, pmc_core_ltr_ignore_show, inode->i_private);
-}
-
-static const struct file_operations pmc_core_ltr_ignore_ops = {
-       .open           = pmc_core_ltr_ignore_open,
-       .read           = seq_read,
-       .write          = pmc_core_ltr_ignore_write,
-       .llseek         = seq_lseek,
-       .release        = single_release,
-};
+DEFINE_SHOW_STORE_ATTRIBUTE(pmc_core_ltr_ignore);
 
 static void pmc_core_slps0_dbg_latch(struct pmc_dev *pmcdev, bool reset)
 {
@@ -1218,7 +1206,7 @@ static void pmc_core_dbgfs_register(struct pmc_dev *pmcdev)
                                    pmcdev, &pmc_core_ppfear_fops);
 
        debugfs_create_file("ltr_ignore", 0644, dir, pmcdev,
-                           &pmc_core_ltr_ignore_ops);
+                           &pmc_core_ltr_ignore_fops);
 
        debugfs_create_file("ltr_show", 0444, dir, pmcdev, &pmc_core_ltr_fops);