clk: imx: pll14xx: Use FIELD_GET/FIELD_PREP

Linux has these marvelous FIELD_GET/FIELD_PREP macros for easy access
to bitfields in registers. Use them and remove the now unused *_SHIFT
defines.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
Link: https://lore.kernel.org/r/20220304125256.2125023-4-s.hauer@pengutronix.de
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>

diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c
index b295d8a049009b5c72a8d5d071e4e1c4782e74e3..fabb380b8730582559637a246e710ade125d57bc 100644 (file)
--- a/drivers/clk/imx/clk-pll14xx.c
+++ b/drivers/clk/imx/clk-pll14xx.c
@@ -3,6 +3,7 @@
  * Copyright 2017-2018 NXP.
  */
 
+#include <linux/bitfield.h>
 #include <linux/bits.h>
 #include <linux/clk-provider.h>
 #include <linux/err.h>
@@ -22,13 +23,9 @@
 #define CLKE_MASK      BIT(11)
 #define RST_MASK       BIT(9)
 #define BYPASS_MASK    BIT(4)
-#define MDIV_SHIFT     12
 #define MDIV_MASK      GENMASK(21, 12)
-#define PDIV_SHIFT     4
 #define PDIV_MASK      GENMASK(9, 4)
-#define SDIV_SHIFT     0
 #define SDIV_MASK      GENMASK(2, 0)
-#define KDIV_SHIFT     0
 #define KDIV_MASK      GENMASK(15, 0)
 
 #define LOCK_TIMEOUT_US                10000
@@ -124,9 +121,9 @@ static unsigned long clk_pll1416x_recalc_rate(struct clk_hw *hw,
        u64 fvco = parent_rate;
 
        pll_div = readl_relaxed(pll->base + DIV_CTL0);
-       mdiv = (pll_div & MDIV_MASK) >> MDIV_SHIFT;
-       pdiv = (pll_div & PDIV_MASK) >> PDIV_SHIFT;
-       sdiv = (pll_div & SDIV_MASK) >> SDIV_SHIFT;
+       mdiv = FIELD_GET(MDIV_MASK, pll_div);
+       pdiv = FIELD_GET(PDIV_MASK, pll_div);
+       sdiv = FIELD_GET(SDIV_MASK, pll_div);
 
        fvco *= mdiv;
        do_div(fvco, pdiv << sdiv);
@@ -144,10 +141,10 @@ static unsigned long clk_pll1443x_recalc_rate(struct clk_hw *hw,
 
        pll_div_ctl0 = readl_relaxed(pll->base + DIV_CTL0);
        pll_div_ctl1 = readl_relaxed(pll->base + DIV_CTL1);
-       mdiv = (pll_div_ctl0 & MDIV_MASK) >> MDIV_SHIFT;
-       pdiv = (pll_div_ctl0 & PDIV_MASK) >> PDIV_SHIFT;
-       sdiv = (pll_div_ctl0 & SDIV_MASK) >> SDIV_SHIFT;
-       kdiv = pll_div_ctl1 & KDIV_MASK;
+       mdiv = FIELD_GET(MDIV_MASK, pll_div_ctl0);
+       pdiv = FIELD_GET(PDIV_MASK, pll_div_ctl0);
+       sdiv = FIELD_GET(SDIV_MASK, pll_div_ctl0);
+       kdiv = FIELD_GET(KDIV_MASK, pll_div_ctl1);
 
        /* fvco = (m * 65536 + k) * Fin / (p * 65536) */
        fvco *= (mdiv * 65536 + kdiv);
@@ -163,8 +160,8 @@ static inline bool clk_pll14xx_mp_change(const struct imx_pll14xx_rate_table *ra
 {
        u32 old_mdiv, old_pdiv;
 
-       old_mdiv = (pll_div & MDIV_MASK) >> MDIV_SHIFT;
-       old_pdiv = (pll_div & PDIV_MASK) >> PDIV_SHIFT;
+       old_mdiv = FIELD_GET(MDIV_MASK, pll_div);
+       old_pdiv = FIELD_GET(PDIV_MASK, pll_div);
 
        return rate->mdiv != old_mdiv || rate->pdiv != old_pdiv;
 }
@@ -196,7 +193,7 @@ static int clk_pll1416x_set_rate(struct clk_hw *hw, unsigned long drate,
 
        if (!clk_pll14xx_mp_change(rate, tmp)) {
                tmp &= ~SDIV_MASK;
-               tmp |= rate->sdiv << SDIV_SHIFT;
+               tmp |= FIELD_PREP(SDIV_MASK, rate->sdiv);
                writel_relaxed(tmp, pll->base + DIV_CTL0);
 
                return 0;
@@ -215,8 +212,8 @@ static int clk_pll1416x_set_rate(struct clk_hw *hw, unsigned long drate,
        tmp |= BYPASS_MASK;
        writel(tmp, pll->base + GNRL_CTL);
 
-       div_val = (rate->mdiv << MDIV_SHIFT) | (rate->pdiv << PDIV_SHIFT) |
-               (rate->sdiv << SDIV_SHIFT);
+       div_val = FIELD_PREP(MDIV_MASK, rate->mdiv) | FIELD_PREP(PDIV_MASK, rate->pdiv) |
+               FIELD_PREP(SDIV_MASK, rate->sdiv);
        writel_relaxed(div_val, pll->base + DIV_CTL0);
 
        /*
@@ -262,10 +259,10 @@ static int clk_pll1443x_set_rate(struct clk_hw *hw, unsigned long drate,
 
        if (!clk_pll14xx_mp_change(rate, tmp)) {
                tmp &= ~SDIV_MASK;
-               tmp |= rate->sdiv << SDIV_SHIFT;
+               tmp |= FIELD_PREP(SDIV_MASK, rate->sdiv);
                writel_relaxed(tmp, pll->base + DIV_CTL0);
 
-               tmp = rate->kdiv << KDIV_SHIFT;
+               tmp = FIELD_PREP(KDIV_MASK, rate->kdiv);
                writel_relaxed(tmp, pll->base + DIV_CTL1);
 
                return 0;
@@ -280,10 +277,11 @@ static int clk_pll1443x_set_rate(struct clk_hw *hw, unsigned long drate,
        tmp |= BYPASS_MASK;
        writel_relaxed(tmp, pll->base + GNRL_CTL);
 
-       div_val = (rate->mdiv << MDIV_SHIFT) | (rate->pdiv << PDIV_SHIFT) |
-               (rate->sdiv << SDIV_SHIFT);
+       div_val = FIELD_PREP(MDIV_MASK, rate->mdiv) |
+                 FIELD_PREP(PDIV_MASK, rate->pdiv) |
+                 FIELD_PREP(SDIV_MASK, rate->sdiv);
        writel_relaxed(div_val, pll->base + DIV_CTL0);
-       writel_relaxed(rate->kdiv << KDIV_SHIFT, pll->base + DIV_CTL1);
+       writel_relaxed(FIELD_PREP(KDIV_MASK, rate->kdiv), pll->base + DIV_CTL1);
 
        /*
         * According to SPEC, t3 - t2 need to be greater than