]> www.infradead.org Git - users/hch/configfs.git/commitdiff
drm/i915: pass dev_priv explicitly to ICL_PIPESTATUS
authorJani Nikula <jani.nikula@intel.com>
Tue, 4 Jun 2024 15:25:42 +0000 (18:25 +0300)
committerJani Nikula <jani.nikula@intel.com>
Fri, 7 Jun 2024 08:13:18 +0000 (11:13 +0300)
Avoid the implicit dev_priv local variable use, and pass dev_priv
explicitly to the ICL_PIPESTATUS register macro.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/d9a7ef1ff8e848cd10729f4ee033d1ef55ee78cc.1717514638.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_fifo_underrun.c
drivers/gpu/drm/i915/i915_reg.h

index 401726f466c094223af0696f5bf05133cb9c2d78..e5e4ca7cc499d0b9192c09ad05c7207c7bc02cbd 100644 (file)
@@ -209,7 +209,8 @@ static void bdw_set_fifo_underrun_reporting(struct drm_device *dev,
 
        if (enable) {
                if (DISPLAY_VER(dev_priv) >= 11)
-                       intel_de_write(dev_priv, ICL_PIPESTATUS(pipe),
+                       intel_de_write(dev_priv,
+                                      ICL_PIPESTATUS(dev_priv, pipe),
                                       icl_pipe_status_underrun_mask(dev_priv));
 
                bdw_enable_pipe_irq(dev_priv, pipe, mask);
@@ -418,9 +419,11 @@ void intel_cpu_fifo_underrun_irq_handler(struct drm_i915_private *dev_priv,
         * the underrun was caused by the downstream port.
         */
        if (DISPLAY_VER(dev_priv) >= 11) {
-               underruns = intel_de_read(dev_priv, ICL_PIPESTATUS(pipe)) &
+               underruns = intel_de_read(dev_priv,
+                                         ICL_PIPESTATUS(dev_priv, pipe)) &
                        icl_pipe_status_underrun_mask(dev_priv);
-               intel_de_write(dev_priv, ICL_PIPESTATUS(pipe), underruns);
+               intel_de_write(dev_priv, ICL_PIPESTATUS(dev_priv, pipe),
+                              underruns);
        }
 
        if (intel_set_cpu_fifo_underrun_reporting(dev_priv, pipe, false)) {
index 0b699bcac759ba92d9b93d2b359bbdd5e0ebab2c..37796427511f147d7882cdf7bb5a1c9373b07468 100644 (file)
 #define PIPE_MISC2(pipe)               _MMIO_PIPE(pipe, _PIPE_MISC2_A, _PIPE_MISC2_B)
 
 #define _ICL_PIPE_A_STATUS                     0x70058
-#define ICL_PIPESTATUS(pipe)                   _MMIO_PIPE2(dev_priv, pipe, _ICL_PIPE_A_STATUS)
+#define ICL_PIPESTATUS(dev_priv, pipe)                 _MMIO_PIPE2(dev_priv, pipe, _ICL_PIPE_A_STATUS)
 #define   PIPE_STATUS_UNDERRUN                         REG_BIT(31)
 #define   PIPE_STATUS_SOFT_UNDERRUN_XELPD              REG_BIT(28)
 #define   PIPE_STATUS_HARD_UNDERRUN_XELPD              REG_BIT(27)