]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
i2c: designware: Uninline i2c_dw_probe()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 10 Sep 2024 16:28:44 +0000 (19:28 +0300)
committerAndi Shyti <andi.shyti@kernel.org>
Wed, 11 Sep 2024 10:52:44 +0000 (12:52 +0200)
Since i2c_dw_probe() is going to be extended, uninline it to reduce
the noise in the common header.

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Tested-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-designware-common.c
drivers/i2c/busses/i2c-designware-core.h

index fb65fe6d8122e7134a221f236accd206c7601c1a..a6dbccd85565b05c6ebade1e4242f5e28ca58f95 100644 (file)
@@ -737,6 +737,20 @@ void i2c_dw_disable(struct dw_i2c_dev *dev)
 }
 EXPORT_SYMBOL_GPL(i2c_dw_disable);
 
+int i2c_dw_probe(struct dw_i2c_dev *dev)
+{
+       switch (dev->mode) {
+       case DW_IC_SLAVE:
+               return i2c_dw_probe_slave(dev);
+       case DW_IC_MASTER:
+               return i2c_dw_probe_master(dev);
+       default:
+               dev_err(dev->dev, "Wrong operation mode: %d\n", dev->mode);
+               return -EINVAL;
+       }
+}
+EXPORT_SYMBOL_GPL(i2c_dw_probe);
+
 static int i2c_dw_prepare(struct device *device)
 {
        /*
index c6bd6f65a2d363fd5c2cecb42ee8c93523e30b3a..1ac2afd03a0a581d81e6900d5dbd1ca43058863e 100644 (file)
@@ -10,9 +10,7 @@
  */
 
 #include <linux/bits.h>
-#include <linux/compiler_types.h>
 #include <linux/completion.h>
-#include <linux/dev_printk.h>
 #include <linux/errno.h>
 #include <linux/i2c.h>
 #include <linux/pm.h>
@@ -388,19 +386,6 @@ static inline void i2c_dw_configure_slave(struct dw_i2c_dev *dev) { }
 static inline int i2c_dw_probe_slave(struct dw_i2c_dev *dev) { return -EINVAL; }
 #endif
 
-static inline int i2c_dw_probe(struct dw_i2c_dev *dev)
-{
-       switch (dev->mode) {
-       case DW_IC_SLAVE:
-               return i2c_dw_probe_slave(dev);
-       case DW_IC_MASTER:
-               return i2c_dw_probe_master(dev);
-       default:
-               dev_err(dev->dev, "Wrong operation mode: %d\n", dev->mode);
-               return -EINVAL;
-       }
-}
-
 static inline void i2c_dw_configure(struct dw_i2c_dev *dev)
 {
        if (i2c_detect_slave_mode(dev->dev))
@@ -409,6 +394,8 @@ static inline void i2c_dw_configure(struct dw_i2c_dev *dev)
                i2c_dw_configure_master(dev);
 }
 
+int i2c_dw_probe(struct dw_i2c_dev *dev);
+
 #if IS_ENABLED(CONFIG_I2C_DESIGNWARE_BAYTRAIL)
 int i2c_dw_baytrail_probe_lock_support(struct dw_i2c_dev *dev);
 #endif