]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
power: supply: core: constify power_supply_battery_info::resist_table
authorThomas Weißschuh <linux@weissschuh.net>
Sat, 5 Oct 2024 10:04:17 +0000 (12:04 +0200)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Tue, 15 Oct 2024 20:14:11 +0000 (22:14 +0200)
The power supply core never modifies the resist table.
Reflect this in the API, so drivers can mark their static tables as
const.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20241005-power-supply-battery-const-v1-1-c1f721927048@weissschuh.net
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/power_supply_core.c
include/linux/power_supply.h

index 49534458a9f7d3f6d7c01bd91fa1bb6ed23bc7ad..a01703fa83c0d90ec630782e67aa3c2c406d51dd 100644 (file)
@@ -798,7 +798,7 @@ int power_supply_get_battery_info(struct power_supply *psy,
                goto out_ret_pointer;
 
        info->resist_table_size = len / (2 * sizeof(__be32));
-       resist_table = info->resist_table = devm_kcalloc(&psy->dev,
+       info->resist_table = resist_table = devm_kcalloc(&psy->dev,
                                                         info->resist_table_size,
                                                         sizeof(*resist_table),
                                                         GFP_KERNEL);
@@ -982,7 +982,7 @@ EXPORT_SYMBOL_GPL(power_supply_battery_info_get_prop);
  *
  * Return: the battery internal resistance percent
  */
-int power_supply_temp2resist_simple(struct power_supply_resistance_temp_table *table,
+int power_supply_temp2resist_simple(const struct power_supply_resistance_temp_table *table,
                                    int table_len, int temp)
 {
        int i, high, low;
index 910d407ebe6323aaf4b31f0081f2cdd4be43a9fa..9253411c105f27177181f9b0a84285a7b24bc954 100644 (file)
@@ -752,7 +752,7 @@ struct power_supply_battery_info {
        int temp_max;
        struct power_supply_battery_ocv_table *ocv_table[POWER_SUPPLY_OCV_TEMP_MAX];
        int ocv_table_size[POWER_SUPPLY_OCV_TEMP_MAX];
-       struct power_supply_resistance_temp_table *resist_table;
+       const struct power_supply_resistance_temp_table *resist_table;
        int resist_table_size;
        const struct power_supply_vbat_ri_table *vbat2ri_discharging;
        int vbat2ri_discharging_size;
@@ -805,7 +805,7 @@ power_supply_find_ocv2cap_table(struct power_supply_battery_info *info,
 extern int power_supply_batinfo_ocv2cap(struct power_supply_battery_info *info,
                                        int ocv, int temp);
 extern int
-power_supply_temp2resist_simple(struct power_supply_resistance_temp_table *table,
+power_supply_temp2resist_simple(const struct power_supply_resistance_temp_table *table,
                                int table_len, int temp);
 extern int power_supply_vbat2ri(struct power_supply_battery_info *info,
                                int vbat_uv, bool charging);