]> www.infradead.org Git - users/hch/misc.git/commitdiff
scsi: ufs: host: mediatek: Fix invalid access in vccqx handling
authorAlice Chao <alice.chao@mediatek.com>
Mon, 11 Aug 2025 13:11:26 +0000 (21:11 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 15 Aug 2025 02:49:13 +0000 (22:49 -0400)
Add a NULL check before accessing the 'vccqx' pointer to prevent invalid
memory access. This ensures that the function safely handles cases where
'vccq' and 'vccq2' are not initialized, improving the robustness of the
power management code.

Signed-off-by: Alice Chao <alice.chao@mediatek.com>
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
Signed-off-by: Peter Wang <peter.wang@mediatek.com>
Link: https://lore.kernel.org/r/20250811131423.3444014-11-peter.wang@mediatek.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/host/ufs-mediatek.c

index 647b6eb053982c58e9749de9d969e33d8bc2fa45..61c8fe135100350e8bd9d5fc54131e96b02c3fc4 100644 (file)
@@ -1629,6 +1629,9 @@ static void ufs_mtk_vccqx_set_lpm(struct ufs_hba *hba, bool lpm)
 {
        struct ufs_vreg *vccqx = NULL;
 
+       if (!hba->vreg_info.vccq && !hba->vreg_info.vccq2)
+               return;
+
        if (hba->vreg_info.vccq)
                vccqx = hba->vreg_info.vccq;
        else