]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
media: subdev: Support privacy led in v4l2_subdev_enable/disable_streams()
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Wed, 24 Apr 2024 15:39:10 +0000 (18:39 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Tue, 4 Jun 2024 06:31:24 +0000 (08:31 +0200)
We support camera privacy leds with the .s_stream() operation, in
call_s_stream(), but we don't have that support when the subdevice
implements .enable/disable_streams() operations.

Add the support by enabling the led when the first stream for a
subdevice is enabled, and disabling the led then the last stream is
disabled.

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Umang Jain <umang.jain@ideasonboard.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/v4l2-core/v4l2-subdev.c

index f256d65cf90f4ed6da156caa15fa1bd769ea148e..daf3636c5aabed54ee05a53c071bedada2a2c015 100644 (file)
@@ -2205,6 +2205,7 @@ int v4l2_subdev_enable_streams(struct v4l2_subdev *sd, u32 pad,
 {
        struct device *dev = sd->entity.graph_obj.mdev->dev;
        struct v4l2_subdev_state *state;
+       bool already_streaming;
        u64 found_streams = 0;
        unsigned int i;
        int ret;
@@ -2253,6 +2254,8 @@ int v4l2_subdev_enable_streams(struct v4l2_subdev *sd, u32 pad,
 
        dev_dbg(dev, "enable streams %u:%#llx\n", pad, streams_mask);
 
+       already_streaming = v4l2_subdev_is_streaming(sd);
+
        /* Call the .enable_streams() operation. */
        ret = v4l2_subdev_call(sd, pad, enable_streams, state, pad,
                               streams_mask);
@@ -2271,6 +2274,9 @@ int v4l2_subdev_enable_streams(struct v4l2_subdev *sd, u32 pad,
                        cfg->enabled = true;
        }
 
+       if (!already_streaming)
+               v4l2_subdev_enable_privacy_led(sd);
+
 done:
        v4l2_subdev_unlock_state(state);
 
@@ -2395,6 +2401,9 @@ int v4l2_subdev_disable_streams(struct v4l2_subdev *sd, u32 pad,
        }
 
 done:
+       if (!v4l2_subdev_is_streaming(sd))
+               v4l2_subdev_disable_privacy_led(sd);
+
        v4l2_subdev_unlock_state(state);
 
        return ret;