ACPI: platform_profile: Move sanity check out of the mutex

The sanity check that the platform handler had choices set doesn't
need the mutex taken.  Move it to earlier in the registration.

Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Tested-by: Matthew Schwartz <matthew.schwartz@linux.dev>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Armin Wolf <W_Armin@gmx.de>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20241206031918.1537-7-mario.limonciello@amd.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

diff --git a/drivers/acpi/platform_profile.c b/drivers/acpi/platform_profile.c
index 927a2f7456c9a49218028597efa21ff4c72cc047..4f5623fc27c0981aa891ecf3c53db5f47758432f 100644 (file)
--- a/drivers/acpi/platform_profile.c
+++ b/drivers/acpi/platform_profile.c
@@ -179,6 +179,13 @@ int platform_profile_register(struct platform_profile_handler *pprof)
 {
        int err;
 
+       /* Sanity check the profile handler */
+       if (!pprof || bitmap_empty(pprof->choices, PLATFORM_PROFILE_LAST) ||
+           !pprof->profile_set || !pprof->profile_get) {
+               pr_err("platform_profile: handler is invalid\n");
+               return -EINVAL;
+       }
+
        mutex_lock(&profile_lock);
        /* We can only have one active profile */
        if (cur_profile) {
@@ -186,13 +193,6 @@ int platform_profile_register(struct platform_profile_handler *pprof)
                return -EEXIST;
        }
 
-       /* Sanity check the profile handler field are set */
-       if (!pprof || bitmap_empty(pprof->choices, PLATFORM_PROFILE_LAST) ||
-               !pprof->profile_set || !pprof->profile_get) {
-               mutex_unlock(&profile_lock);
-               return -EINVAL;
-       }
-
        err = sysfs_create_group(acpi_kobj, &platform_profile_group);
        if (err) {
                mutex_unlock(&profile_lock);