]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
wifi: ath12k: Remove unused tcl_*_ring configuration
authorTamizh Chelvam Raja <quic_tamizhr@quicinc.com>
Tue, 30 Apr 2024 09:14:14 +0000 (14:44 +0530)
committerKalle Valo <quic_kvalo@quicinc.com>
Tue, 7 May 2024 10:08:49 +0000 (13:08 +0300)
Currently memory allocation for multiple hardware rings done
in host as these memory will be used by firmware/hardware.
But in case of tcl_cmd_ring and tcl_status_ring neither firmware
nor hardware uses host allocated memory and it uses memory
allocated by firmware itself. So avoid tcl_cmd_ring and
tcl_status_ring setup in host.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1

Signed-off-by: Tamizh Chelvam Raja <quic_tamizhr@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://msgid.link/20240430091414.2486196-4-quic_tamizhr@quicinc.com
drivers/net/wireless/ath/ath12k/dp.c
drivers/net/wireless/ath/ath12k/dp.h

index 72ea9baaf8d70e7fc2bce0d1c6379ee0243fc665..ca41f44313948f2aefe56b0f41a96d30cffa513c 100644 (file)
@@ -457,8 +457,6 @@ static void ath12k_dp_srng_common_cleanup(struct ath12k_base *ab)
                ath12k_dp_srng_cleanup(ab, &dp->tx_ring[i].tcl_comp_ring);
                ath12k_dp_srng_cleanup(ab, &dp->tx_ring[i].tcl_data_ring);
        }
-       ath12k_dp_srng_cleanup(ab, &dp->tcl_status_ring);
-       ath12k_dp_srng_cleanup(ab, &dp->tcl_cmd_ring);
        ath12k_dp_srng_cleanup(ab, &dp->wbm_desc_rel_ring);
 }
 
@@ -479,20 +477,6 @@ static int ath12k_dp_srng_common_setup(struct ath12k_base *ab)
                goto err;
        }
 
-       ret = ath12k_dp_srng_setup(ab, &dp->tcl_cmd_ring, HAL_TCL_CMD, 0, 0,
-                                  DP_TCL_CMD_RING_SIZE);
-       if (ret) {
-               ath12k_warn(ab, "failed to set up tcl_cmd ring :%d\n", ret);
-               goto err;
-       }
-
-       ret = ath12k_dp_srng_setup(ab, &dp->tcl_status_ring, HAL_TCL_STATUS,
-                                  0, 0, DP_TCL_STATUS_RING_SIZE);
-       if (ret) {
-               ath12k_warn(ab, "failed to set up tcl_status ring :%d\n", ret);
-               goto err;
-       }
-
        for (i = 0; i < ab->hw_params->max_tx_ring; i++) {
                map = ab->hw_params->hal_ops->tcl_to_wbm_rbm_map;
                tx_comp_ring_num = map[i].wbm_ring_num;
index e9880b34a7abeeb5ebc182698b2fa82b63b08e46..43589c3dd4bc134867edeca07726cbea8582f85c 100644 (file)
@@ -328,8 +328,6 @@ struct ath12k_dp {
        enum hal_rx_buf_return_buf_manager idle_link_rbm;
        struct dp_srng wbm_idle_ring;
        struct dp_srng wbm_desc_rel_ring;
-       struct dp_srng tcl_cmd_ring;
-       struct dp_srng tcl_status_ring;
        struct dp_srng reo_reinject_ring;
        struct dp_srng rx_rel_ring;
        struct dp_srng reo_except_ring;