]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
bpf: Fix uprobe_multi get_pid_task error path
authorJiri Olsa <jolsa@kernel.org>
Fri, 15 Sep 2023 10:14:20 +0000 (12:14 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 15 Sep 2023 17:32:40 +0000 (10:32 -0700)
Dan reported Smatch static checker warning due to missing error
value set in uprobe multi link's get_pid_task error path.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/bpf/c5ffa7c0-6b06-40d5-aca2-63833b5cd9af@moroto.mountain/
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Reviewed-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20230915101420.1193800-1-jolsa@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/trace/bpf_trace.c

index c1c1af63ced2627c13688a8b0fcf6277e67952f2..868008f56fec24fe7030d2fed9b063d1e1dd7926 100644 (file)
@@ -3223,8 +3223,10 @@ int bpf_uprobe_multi_link_attach(const union bpf_attr *attr, struct bpf_prog *pr
                rcu_read_lock();
                task = get_pid_task(find_vpid(pid), PIDTYPE_PID);
                rcu_read_unlock();
-               if (!task)
+               if (!task) {
+                       err = -ESRCH;
                        goto error_path_put;
+               }
        }
 
        err = -ENOMEM;