]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drivers/xen: Use never-managed version of pci_intx()
authorPhilipp Stanner <pstanner@redhat.com>
Mon, 9 Dec 2024 13:06:24 +0000 (14:06 +0100)
committerBjorn Helgaas <bhelgaas@google.com>
Sat, 18 Jan 2025 20:38:48 +0000 (14:38 -0600)
pci_intx() is a hybrid function which can sometimes be managed through
devres. To remove this hybrid nature from pci_intx(), it is necessary to
port users to either an always-managed or a never-managed version.

xen enables its PCI device with pci_enable_device(). Thus, it needs the
never-managed version.

Replace pci_intx() with pci_intx_unmanaged().

Link: https://lore.kernel.org/r/20241209130632.132074-4-pstanner@redhat.com
Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Juergen Gross <jgross@suse.com>
drivers/xen/xen-pciback/conf_space_header.c

index fc0332645966443d2e5c7256c76b488a0b7a783b..8d26d64232e86d8ea433a503f04d63b846d8f58d 100644 (file)
@@ -106,7 +106,7 @@ static int command_write(struct pci_dev *dev, int offset, u16 value, void *data)
 
        if (dev_data && dev_data->allow_interrupt_control &&
            ((cmd->val ^ value) & PCI_COMMAND_INTX_DISABLE))
-               pci_intx(dev, !(value & PCI_COMMAND_INTX_DISABLE));
+               pci_intx_unmanaged(dev, !(value & PCI_COMMAND_INTX_DISABLE));
 
        cmd->val = value;