]> www.infradead.org Git - users/hch/misc.git/commitdiff
PCI: endpoint: pci-ep-msi: Fix NULL vs IS_ERR() check in pci_epf_write_msi_msg()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 1 Aug 2025 13:34:45 +0000 (16:34 +0300)
committerManivannan Sadhasivam <mani@kernel.org>
Mon, 11 Aug 2025 10:58:33 +0000 (16:28 +0530)
The pci_epc_get() function returns error pointers. It never returns NULL.
Update the check to match.

Fixes: 1c3b002c6bf6 ("PCI: endpoint: Add RC-to-EP doorbell support using platform MSI controller")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/aIzCdV8jyBeql-Oa@stanley.mountain
drivers/pci/endpoint/pci-ep-msi.c

index 9ca89cbfec15dfb05593cb412e4e23a807d49560..1b58357b905fab8b63d931f95ad4afbe4f783488 100644 (file)
@@ -24,7 +24,7 @@ static void pci_epf_write_msi_msg(struct msi_desc *desc, struct msi_msg *msg)
        struct pci_epf *epf;
 
        epc = pci_epc_get(dev_name(msi_desc_to_dev(desc)));
-       if (!epc)
+       if (IS_ERR(epc))
                return;
 
        epf = list_first_entry_or_null(&epc->pci_epf, struct pci_epf, list);