ionic: add new queue features to interface

Add queue feature extensions to prepare for features that
can be queue specific, in addition to the general queue
features already defined.  While we're here, change the
existing feature ids from #defines to enum.

Signed-off-by: Allen Hubbe <allenbh@pensando.io>
Signed-off-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/pensando/ionic/ionic_dev.h b/drivers/net/ethernet/pensando/ionic/ionic_dev.h
index 0c0533737b2b07f404b0d148241119c34ee9db5f..68e5e7a978015b7b6443e3a078b21097455f70a3 100644 (file)
--- a/drivers/net/ethernet/pensando/ionic/ionic_dev.h
+++ b/drivers/net/ethernet/pensando/ionic/ionic_dev.h
@@ -222,6 +222,7 @@ struct ionic_queue {
        u64 stop;
        u64 wake;
        u64 drop;
+       u64 features;
        struct ionic_dev *idev;
        unsigned int type;
        unsigned int hw_index;

diff --git a/drivers/net/ethernet/pensando/ionic/ionic_if.h b/drivers/net/ethernet/pensando/ionic/ionic_if.h
index 88210142395d646ce3036438408e81138778eedb..23043ce0a5d84576d3986c47f3e9ef8975542dc9 100644 (file)
--- a/drivers/net/ethernet/pensando/ionic/ionic_if.h
+++ b/drivers/net/ethernet/pensando/ionic/ionic_if.h
@@ -345,6 +345,23 @@ enum ionic_logical_qtype {
        IONIC_QTYPE_MAX     = 16,
 };
 
+/**
+ * enum ionic_q_feature - Common Features for most queue types
+ *
+ * Common features use bits 0-15. Per-queue-type features use higher bits.
+ *
+ * @IONIC_QIDENT_F_CQ:      Queue has completion ring
+ * @IONIC_QIDENT_F_SG:      Queue has scatter/gather ring
+ * @IONIC_QIDENT_F_EQ:      Queue can use event queue
+ * @IONIC_QIDENT_F_CMB:     Queue is in cmb bar
+ */
+enum ionic_q_feature {
+       IONIC_QIDENT_F_CQ               = BIT_ULL(0),
+       IONIC_QIDENT_F_SG               = BIT_ULL(1),
+       IONIC_QIDENT_F_EQ               = BIT_ULL(2),
+       IONIC_QIDENT_F_CMB              = BIT_ULL(3),
+};
+
 /**
  * struct ionic_lif_logical_qtype - Descriptor of logical to HW queue type
  * @qtype:          Hardware Queue Type
@@ -529,7 +546,7 @@ struct ionic_q_identify_comp {
  * union ionic_q_identity - queue identity information
  *     @version:        Queue type version that can be used with FW
  *     @supported:      Bitfield of queue versions, first bit = ver 0
- *     @features:       Queue features
+ *     @features:       Queue features (enum ionic_q_feature, etc)
  *     @desc_sz:        Descriptor size
  *     @comp_sz:        Completion descriptor size
  *     @sg_desc_sz:     Scatter/Gather descriptor size
@@ -541,10 +558,6 @@ union ionic_q_identity {
                u8      version;
                u8      supported;
                u8      rsvd[6];
-#define IONIC_QIDENT_F_CQ      0x01    /* queue has completion ring */
-#define IONIC_QIDENT_F_SG      0x02    /* queue has scatter/gather ring */
-#define IONIC_QIDENT_F_EQ      0x04    /* queue can use event queue */
-#define IONIC_QIDENT_F_CMB     0x08    /* queue is in cmb bar */
                __le64  features;
                __le16  desc_sz;
                __le16  comp_sz;
@@ -585,6 +598,7 @@ union ionic_q_identity {
  * @ring_base:    Queue ring base address
  * @cq_ring_base: Completion queue ring base address
  * @sg_ring_base: Scatter/Gather ring base address
+ * @features:     Mask of queue features to enable, if not in the flags above.
  */
 struct ionic_q_init_cmd {
        u8     opcode;
@@ -608,7 +622,8 @@ struct ionic_q_init_cmd {
        __le64 ring_base;
        __le64 cq_ring_base;
        __le64 sg_ring_base;
-       u8     rsvd2[20];
+       u8     rsvd2[12];
+       __le64 features;
 } __packed;
 
 /**

diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
index a51be25723a58063cdf242382065324694e211dc..1b89549b243b5c44272378652dc12c9cafe0f83d 100644 (file)
--- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
@@ -731,6 +731,7 @@ static int ionic_lif_txq_init(struct ionic_lif *lif, struct ionic_qcq *qcq)
                        .ring_base = cpu_to_le64(q->base_pa),
                        .cq_ring_base = cpu_to_le64(cq->base_pa),
                        .sg_ring_base = cpu_to_le64(q->sg_base_pa),
+                       .features = cpu_to_le64(q->features),
                },
        };
        unsigned int intr_index;
@@ -791,6 +792,7 @@ static int ionic_lif_rxq_init(struct ionic_lif *lif, struct ionic_qcq *qcq)
                        .ring_base = cpu_to_le64(q->base_pa),
                        .cq_ring_base = cpu_to_le64(cq->base_pa),
                        .sg_ring_base = cpu_to_le64(q->sg_base_pa),
+                       .features = cpu_to_le64(q->features),
                },
        };
        int err;
@@ -2214,6 +2216,7 @@ static const struct net_device_ops ionic_netdev_ops = {
 static void ionic_swap_queues(struct ionic_qcq *a, struct ionic_qcq *b)
 {
        /* only swapping the queues, not the napi, flags, or other stuff */
+       swap(a->q.features,   b->q.features);
        swap(a->q.num_descs,  b->q.num_descs);
        swap(a->q.base,       b->q.base);
        swap(a->q.base_pa,    b->q.base_pa);