]> www.infradead.org Git - users/hch/misc.git/commitdiff
net: dsa: mv88e6xxx: remove chip->trig_config
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thu, 11 Sep 2025 10:46:33 +0000 (11:46 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sun, 14 Sep 2025 18:56:23 +0000 (11:56 -0700)
chip->trig_config is never written, and thus takes the value zero.
Remove this struct member and its single reader.

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1uweoz-00000004ik7-13Fl@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/mv88e6xxx/chip.h
drivers/net/dsa/mv88e6xxx/ptp.c

index feddf505c9186e3be085d8f9f2f5d7fd083f9e32..9beaffb2eb12cdf21e8d04e25d8fcd2efaa27c52 100644 (file)
@@ -424,7 +424,6 @@ struct mv88e6xxx_chip {
        struct ptp_clock_info   ptp_clock_info;
        struct delayed_work     tai_event_work;
        struct ptp_pin_desc     pin_config[MV88E6XXX_MAX_GPIO];
-       u16 trig_config;
        u16 evcap_config;
        u16 enable_count;
 
index 62a74bcdc90af2b549d8c904dfdb407acd739973..402328b9349b31c45d32307bb1935bd7c1f043ba 100644 (file)
@@ -184,7 +184,7 @@ static int mv88e6352_config_eventcap(struct mv88e6xxx_chip *chip, int event,
        if (!rising)
                chip->evcap_config |= MV88E6XXX_TAI_CFG_EVREQ_FALLING;
 
-       global_config = (chip->evcap_config | chip->trig_config);
+       global_config = chip->evcap_config;
        err = mv88e6xxx_tai_write(chip, MV88E6XXX_TAI_CFG, global_config);
        if (err)
                return err;