]> www.infradead.org Git - users/sagi/blktests.git/commitdiff
nvme/046: change nvme io-passthru command option from -o to --opcode
authorShin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Fri, 26 Jan 2024 06:10:37 +0000 (15:10 +0900)
committerShin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Thu, 1 Feb 2024 11:20:07 +0000 (20:20 +0900)
A recent commit in nvme-cli v2.6 changed the single letter of the
--opcode option from -o to -O. This caused the failure of nvme/046. To
make the test case work regardless of the nvme-cli version, replace -o
with --opcode.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
tests/nvme/046

index 942f25206c174c47df07143b17d955b239c66d1b..7576a24f234d13e38907f5d323691fd038a0bef7 100755 (executable)
@@ -25,13 +25,13 @@ test_device() {
 
        chmod g+r,o+r "$ngdev"
 
-       if ! _run_user "nvme io-passthru ${ngdev} -o 2 -l 4096 \
+       if ! _run_user "nvme io-passthru ${ngdev} --opcode 2 -l 4096 \
                -n $nsid -r" >> "${FULL}" 2>&1; then
                echo "Error: io-passthru read failed"
        fi
 
-       if _run_user "echo hello | nvme io-passthru ${ngdev} -o 1 -l 4096 \
-               -n $nsid -r" >> "${FULL}" 2>&1; then
+       if _run_user "echo hello | nvme io-passthru ${ngdev} --opcode 1 \
+               -l 4096 -n $nsid -r" >> "${FULL}" 2>&1; then
                echo "Error: io-passthru write passed (unexpected)"
        fi