scsi: qedi: Fix null ref during abort handling

If qedi_process_cmd_cleanup_resp finds the cmd it frees the work and sets
list_tmf_work to NULL, so qedi_tmf_work should check if list_tmf_work is
non-NULL when it wants to force cleanup.

Link: https://lore.kernel.org/r/20210525181821.7617-20-michael.christie@oracle.com
Reviewed-by: Manish Rangankar <mrangankar@marvell.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c
index 440ddd2309f1dd1ee13f91c9e796297e1b1c5fdf..cf57b4e49700fd25869632b3afc577d800eaea4f 100644 (file)
--- a/drivers/scsi/qedi/qedi_fw.c
+++ b/drivers/scsi/qedi/qedi_fw.c
@@ -1453,7 +1453,7 @@ abort_ret:
 
 ldel_exit:
        spin_lock_bh(&qedi_conn->tmf_work_lock);
-       if (!qedi_cmd->list_tmf_work) {
+       if (qedi_cmd->list_tmf_work) {
                list_del_init(&list_work->list);
                qedi_cmd->list_tmf_work = NULL;
                kfree(list_work);