SDP: A better fix of a potential memory leak in the new bzcopy code.

Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il>

diff --git a/drivers/infiniband/ulp/sdp/sdp_main.c b/drivers/infiniband/ulp/sdp/sdp_main.c
index 809f7b8aaf8a394720eb8116f2393d371274e8f2..583187c927a7f03282aa08d2b49f58f898135fbd 100644 (file)
--- a/drivers/infiniband/ulp/sdp/sdp_main.c
+++ b/drivers/infiniband/ulp/sdp/sdp_main.c
@@ -1240,10 +1240,6 @@ static struct bzcopy_state *sdp_bz_setup(struct sdp_sock *ssk,
        if (!can_do_mlock())
                return NULL;
 
-       bz = kzalloc(sizeof(*bz), GFP_KERNEL);
-       if (!bz)
-               return NULL;
-
        /*
         *   Since we use the TCP segmentation fields of the skb to map user
         * pages, we must make sure that everything we send in a single chunk
@@ -1253,6 +1249,10 @@ static struct bzcopy_state *sdp_bz_setup(struct sdp_sock *ssk,
        if (size_goal >= MAX_SKB_FRAGS)
                return NULL;
 
+       bz = kzalloc(sizeof(*bz), GFP_KERNEL);
+       if (!bz)
+               return NULL;
+
        addr = (unsigned long)base;
 
        bz->u_base     = base;