]> www.infradead.org Git - linux.git/commitdiff
of: Compare property names by of_prop_cmp() in of_alias_scan()
authorZijun Hu <quic_zijuhu@quicinc.com>
Mon, 24 Feb 2025 14:27:57 +0000 (22:27 +0800)
committerRob Herring (Arm) <robh@kernel.org>
Tue, 25 Feb 2025 14:42:43 +0000 (08:42 -0600)
For these pseudo property names 'name', 'phandle' and 'linux,phandle':

Use dedicated property name comparison macro of_prop_cmp() instead of
strcmp() in of_alias_scan() to:

- Make property name comparison consistent.
- Prepare for introducing private is_pseudo_property() later.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20250224-of_bugfix-v1-1-03640ae8c3a6@quicinc.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
drivers/of/base.c

index af6c68bbb4277e4f66deef886a2df8d1b6f114cf..d2d41601136bc8ee2b97e31b83af1b361ba03261 100644 (file)
@@ -1855,9 +1855,9 @@ void of_alias_scan(void * (*dt_alloc)(u64 size, u64 align))
                int id, len;
 
                /* Skip those we do not want to proceed */
-               if (!strcmp(pp->name, "name") ||
-                   !strcmp(pp->name, "phandle") ||
-                   !strcmp(pp->name, "linux,phandle"))
+               if (!of_prop_cmp(pp->name, "name") ||
+                   !of_prop_cmp(pp->name, "phandle") ||
+                   !of_prop_cmp(pp->name, "linux,phandle"))
                        continue;
 
                np = of_find_node_by_path(pp->value);