]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
arm64: dts: qcom: x1e78100-t14s: fix missing HID supplies
authorJohan Hovold <johan+linaro@kernel.org>
Fri, 14 Mar 2025 14:54:40 +0000 (15:54 +0100)
committerBjorn Andersson <andersson@kernel.org>
Fri, 14 Mar 2025 21:07:31 +0000 (16:07 -0500)
Add the missing HID supplies to avoid relying on other consumers to keep
them on.

This also avoids the following warnings on boot:

i2c_hid_of 0-0010: supply vdd not found, using dummy regulator
i2c_hid_of 0-0010: supply vddl not found, using dummy regulator
i2c_hid_of 1-0015: supply vdd not found, using dummy regulator
i2c_hid_of 1-002c: supply vdd not found, using dummy regulator
i2c_hid_of 1-0015: supply vddl not found, using dummy regulator
i2c_hid_of 1-002c: supply vddl not found, using dummy regulator
i2c_hid_of 1-003a: supply vdd not found, using dummy regulator
i2c_hid_of 1-003a: supply vddl not found, using dummy regulator

Note that VCC3B is also used for things like the modem which are not yet
described so mark the regulator as always-on for now.

Fixes: 7d1cbe2f4985 ("arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6")
Cc: stable@vger.kernel.org # 6.12
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20250314145440.11371-9-johan+linaro@kernel.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi

index 160c052db1ecfd174e0bf624de1f5d697b178552..962fb050c55c4fd33f480a21a8c47a484d0c82b8 100644 (file)
@@ -9,6 +9,7 @@
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/gpio-keys.h>
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
 #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
 
 #include "x1e80100.dtsi"
                regulator-boot-on;
        };
 
+       vreg_misc_3p3: regulator-misc-3p3 {
+               compatible = "regulator-fixed";
+
+               regulator-name = "VCC3B";
+               regulator-min-microvolt = <3300000>;
+               regulator-max-microvolt = <3300000>;
+
+               gpio = <&pm8550ve_8_gpios 6 GPIO_ACTIVE_HIGH>;
+               enable-active-high;
+
+               pinctrl-0 = <&misc_3p3_reg_en>;
+               pinctrl-names = "default";
+
+               regulator-boot-on;
+               regulator-always-on;
+       };
+
        vreg_nvme: regulator-nvme {
                compatible = "regulator-fixed";
 
                hid-descr-addr = <0x1>;
                interrupts-extended = <&tlmm 3 IRQ_TYPE_LEVEL_LOW>;
 
+               vdd-supply = <&vreg_misc_3p3>;
+               vddl-supply = <&vreg_l12b_1p2>;
+
                wakeup-source;
        };
 
                hid-descr-addr = <0x20>;
                interrupts-extended = <&tlmm 3 IRQ_TYPE_LEVEL_LOW>;
 
+               vdd-supply = <&vreg_misc_3p3>;
+               vddl-supply = <&vreg_l12b_1p2>;
+
                wakeup-source;
        };
 
                hid-descr-addr = <0x1>;
                interrupts-extended = <&tlmm 67 IRQ_TYPE_LEVEL_LOW>;
 
+               vdd-supply = <&vreg_misc_3p3>;
+               vddl-supply = <&vreg_l15b_1p8>;
+
                pinctrl-0 = <&kybd_default>;
                pinctrl-names = "default";
 
                hid-descr-addr = <0x1>;
                interrupts-extended = <&tlmm 51 IRQ_TYPE_LEVEL_LOW>;
 
+               vdd-supply = <&vreg_misc_3p3>;
+               vddl-supply = <&vreg_l15b_1p8>;
+
                pinctrl-0 = <&ts0_default>;
                pinctrl-names = "default";
        };
        };
 };
 
+&pm8550ve_8_gpios {
+       misc_3p3_reg_en: misc-3p3-reg-en-state {
+               pins = "gpio6";
+               function = "normal";
+               bias-disable;
+               drive-push-pull;
+               input-disable;
+               output-enable;
+               power-source = <1>; /* 1.8 V */
+               qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>;
+       };
+};
+
 &pm8550ve_9_gpios {
        usb0_1p8_reg_en: usb0-1p8-reg-en-state {
                pins = "gpio8";