]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
nfsd: simplify test_bit return in NFSD_FILE_KEY_FULL comparator
authorJeff Layton <jlayton@kernel.org>
Fri, 6 Jan 2023 15:39:01 +0000 (10:39 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:19:27 +0000 (16:19 +0200)
[ Upstream commit d69b8dbfd0866abc5ec84652cc1c10fc3d4d91ef ]

test_bit returns bool, so we can just compare the result of that to the
key->gc value without the "!!".

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/filecache.c

index 4ddc82b84f7c4809638f44361f65498394cd4aa2..d61c8223082a4a602284b4fe1e23e8ca19603d4d 100644 (file)
@@ -188,7 +188,7 @@ static int nfsd_file_obj_cmpfn(struct rhashtable_compare_arg *arg,
                        return 1;
                if (!nfsd_match_cred(nf->nf_cred, key->cred))
                        return 1;
-               if (!!test_bit(NFSD_FILE_GC, &nf->nf_flags) != key->gc)
+               if (test_bit(NFSD_FILE_GC, &nf->nf_flags) != key->gc)
                        return 1;
                if (test_bit(NFSD_FILE_HASHED, &nf->nf_flags) == 0)
                        return 1;