]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
media: exynos4-is: Request syscon only if ISP writeback is present
authorTomasz Figa <tomasz.figa@gmail.com>
Thu, 30 Jul 2020 23:01:05 +0000 (01:01 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 1 Sep 2020 12:13:25 +0000 (14:13 +0200)
On FIMC variants which don't have writeback channel, there is no need to
access system registers. This patch makes the driver request sysreg
regmap conditionally depending on whether writeback is supported.

Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/exynos4-is/fimc-core.c

index 2258f3bfc929eb44b5da9a25965ae260fd5ec431..08d1f39a914c57ed19d79644ba348397c7742c7c 100644 (file)
@@ -954,9 +954,11 @@ static int fimc_probe(struct platform_device *pdev)
        spin_lock_init(&fimc->slock);
        mutex_init(&fimc->lock);
 
-       fimc->sysreg = fimc_get_sysreg_regmap(dev->of_node);
-       if (IS_ERR(fimc->sysreg))
-               return PTR_ERR(fimc->sysreg);
+       if (fimc->variant->has_isp_wb) {
+               fimc->sysreg = fimc_get_sysreg_regmap(dev->of_node);
+               if (IS_ERR(fimc->sysreg))
+                       return PTR_ERR(fimc->sysreg);
+       }
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        fimc->regs = devm_ioremap_resource(dev, res);